Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sbt 1.4.9 (was 1.4.7); and standardize JDK+sbt setup #403

Merged
merged 2 commits into from
Mar 31, 2021

Conversation

SethTisue
Copy link
Member

No description provided.

scala-steward and others added 2 commits March 15, 2021 21:09

Verified

This commit was signed with the committer’s verified signature.
scala-steward Scala Steward
The issue here is that by default, Travis-CI has an outdated
sbt-extras script that doesn't work with sbt 1.4.8+.

A more minimal fix would be to add the workaround suggested
in the sbt 1.4.8 and 1.4.9 release notes.

But down that path lies further hand-maintenance.  I think it's better
to use the Travis-CI stuff in the scala-dev repo, which is maintained
by the Scala team at lightbend. It handles JDK installation (via
SDKMAN not Jabba), addresses the sbt 1.4.8+ issue (and will address
any other such issues that arise in the future), and handles
caching, too.
@SethTisue SethTisue mentioned this pull request Mar 17, 2021
@SethTisue
Copy link
Member Author

@ignasi35 lgty?

@SethTisue
Copy link
Member Author

@mkurz ?

@SethTisue
Copy link
Member Author

@marcospereira ? @octonato ?

Copy link
Contributor

@octonato octonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks @SethTisue

@octonato octonato merged commit b2f48ff into playframework:master Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants